Mac OS X 10.6 - 10.9 is back with Monit 5.22.0

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Mac OS X 10.6 - 10.9 is back with Monit 5.22.0

Lutz Mader
Hello Martin,
nice to see the Mac OS X 10.6 support is back again.
I try to build monit 5.21.0 for Mac OS X 10.5 (ppc) and 10.6 (x86), but
it doesn't work. Some code in "./device/sysdep_DARWIN.c" and
"./process/sysdep_DARWIN.c" doesn't fit to Mac OS X 10.6.

> Fixed: Issue #584: Compile on MacOSX 10.6.x - 10.9.x.

Thanks,
Lutz

p.s.
I know, OS X 10.5/10.6 is old, but is still running well.


--
To unsubscribe:
https://lists.nongnu.org/mailman/listinfo/monit-general
Reply | Threaded
Open this post in threaded view
|

Re: Mac OS X 10.6 - 10.9 is back with Monit 5.22.0

martinp@tildeslash.com
Hello Lutz,

i cannot reproduce the issue - Monit 5.22.0 compiles fine on our MacOS 10.6 machine. Please can you send the error output?

Best regards,
Martin


> On 20 Apr 2017, at 14:05, Lutz Mader <[hidden email]> wrote:
>
> Hello Martin,
> nice to see the Mac OS X 10.6 support is back again.
> I try to build monit 5.21.0 for Mac OS X 10.5 (ppc) and 10.6 (x86), but
> it doesn't work. Some code in "./device/sysdep_DARWIN.c" and
> "./process/sysdep_DARWIN.c" doesn't fit to Mac OS X 10.6.
>
>> Fixed: Issue #584: Compile on MacOSX 10.6.x - 10.9.x.
>
> Thanks,
> Lutz
>
> p.s.
> I know, OS X 10.5/10.6 is old, but is still running well.
>
>
> --
> To unsubscribe:
> https://lists.nongnu.org/mailman/listinfo/monit-general


--
To unsubscribe:
https://lists.nongnu.org/mailman/listinfo/monit-general
Reply | Threaded
Open this post in threaded view
|

Re: Mac OS X 10.6 - 10.9 is back with Monit 5.22.0

Lutz Mader
Hello Martin,
nice to know, but I can't, sorry.

> i cannot reproduce the issue - Monit 5.22.0 compiles fine on our
> MacOS 10.6 machine. Please can you send the error output?

I checked all my modifications basedn on 5.21.0 with 5.22.0 again.

Without any modification and with "./configure" and "make" I got the
following problem. Based on the configure output I can't find a problem
in general.

src/device/sysdep_DARWIN.c:102: warning: implicit declaration of
function ‘DADiskCreateFromVolumePath’
src/device/sysdep_DARWIN.c:102: warning: initialization makes pointer
from integer without a cast
src/device/sysdep_DARWIN.c: In function ‘_filesystemFlagsToString’:
src/device/sysdep_DARWIN.c:187: error: ‘MNT_CPROTECT’ undeclared (first
use in this function)
src/device/sysdep_DARWIN.c:187: error: (Each undeclared identifier is
reported only once
src/device/sysdep_DARWIN.c:187: error: for each function it appears in.)
make[2]: *** [src/device/sysdep_DARWIN.o] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

I removed MNT_CPROTECT (see below) and get something like the following.

src/device/sysdep_DARWIN.c:33: error: expected identifier or '(' before
'<' token
src/device/sysdep_DARWIN.c:34: error: stray '#' in program
src/device/sysdep_DARWIN.c: In function '_getBlockDiskActivity':
src/device/sysdep_DARWIN.c:105: warning: implicit declaration of
function 'DADiskCreateFromVolumePath'
src/device/sysdep_DARWIN.c:105: warning: initialization makes pointer
from integer without a cast
make[2]: *** [src/device/sysdep_DARWIN.o] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

But I don't know an easy fix.

With regards,
Lutz

appendage:
The changes to device/sysdep_DARWIN.c I used.

--- device/sysdep_DARWIN_orig.c 2017-04-19 15:19:49.000000000 +0200
+++ device/sysdep_DARWIN.c 2017-04-20 15:58:42.000000000 +0200
@@ -30,6 +30,9 @@

 #include "config.h"

+< /* This gets us MAC_OS_X_VERSION_MIN_REQUIRED... */
+< #include <AvailabilityMacros.h>
+
 #ifdef HAVE_STDIO_H
 #include <stdio.h>
 #endif
@@ -184,7 +187,9 @@
                 {MNT_NODEV, "nodev"},
                 {MNT_UNION, "union"},
                 {MNT_ASYNC, "async"},
+#if MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
                 {MNT_CPROTECT, "content protection"},
+#endif
                 {MNT_EXPORTED, "exported"},
                 {MNT_QUARANTINE, "quarantined"},
                 {MNT_LOCAL, "local"},


--
To unsubscribe:
https://lists.nongnu.org/mailman/listinfo/monit-general