Monotone fails to build with PCRE 8.42

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Monotone fails to build with PCRE 8.42

Petr Pisar
Hello,

monotone-1.1 fails to build with PCRE 8.42:

g++  -I.    -I/usr/include/botan-1.10           -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection -Wall -W -Wno-unused -c -o src/pcrewrap.o src/pcrewrap.cc
src/pcrewrap.cc: In destructor 'pcre::regex_cache_manager::~regex_cache_manager()':
src/pcrewrap.cc:107:64: error: invalid const_cast from type 'const real_pcre*' to type 'pcre_t*' {aka 'real_pcre8_or_16*'}
               pcre_free(const_cast<pcre_t *>(iter->second.first));
                                                                ^

Attached patch adapts monotone.

By the way, PCRE is obsoleted by PCRE2. If monotone want to use a supported
regular expression engine, it should migrate to PCRE2.

-- Petr

_______________________________________________
Monotone-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/monotone-devel

monotone-1.1-Adapt-to-changes-in-pcre-8.42.patch (2K) Download Attachment
signature.asc (235 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Monotone fails to build with PCRE 8.42

Markus Wanner-2
Hello Petr,

On 07.05.2018 14:24, Petr Pisar wrote:
> monotone-1.1 fails to build with PCRE 8.42:

> By the way, PCRE is obsoleted by PCRE2.

thanks a lot for these hints. I'll eventually take a look. A monotone
1.2 release is way overdue.

Kind Regards

Markus Wanner


_______________________________________________
Monotone-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/monotone-devel

signature.asc (235 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Monotone fails to build with PCRE 8.42

Lapo Luchini
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Markus Wanner wrote:
>> By the way, PCRE is obsoleted by PCRE2.
>
> thanks a lot for these hints. I'll eventually take a look.

Someday I'd also like to take a look at RE2 instead of PCRE, as it is
implemented with FSA and not backtracking.

But for the sake of it, it shouldn't make a real difference in our
usecase, I guess.

http://lh3lh3.users.sourceforge.net/reb.shtml

- --
Lapo Luchini - http://lapo.it/
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEFlFdHtWKvLA2wx9Zg7C4xsvacfAFAlr7BJgACgkQg7C4xsva
cfCDgRAAx+HaetM46jTKkXRziVH2IiUTKcXT+FbElIUpMa2jvkdU10P9Wvbjvg27
Zm0ihoxtRFuPVzhPx+ZhrxB5x3woTuL+jDnhb6ni3AadaU8cgYVkARl/C+hMVWRe
r2F/+KJzjEFGv4qLSTNB6xhIucCZemHNjrVmYqZNhcJKHXoXNmdWlsTHPLhUNjwJ
usVg/4q+JXAIS2CIbQPEWKiD4hWnxDBoZrTGz5JSfIQJXRp7qHsuwq/o2C2FP9zz
n2izXD0yMbgqcxazCrK8wbIMRZWs69D4upUIiuW6CgVE22StDfDrL5Wt8frmXy9l
3hvOQ9CFs5FbZDk15s7e2IvfDUz7C4t6r5GWj51V2wgDYSWNiCxlTBXA3WDQ0alH
HrD0pluhBe0Q+4etGHGBxdzs/ITLV5JCfNGvRrdnRS2C5zVUXMgEgLiBm3hSJznG
goMrLZAZH9RVE3ifWA25OHbgN+59bD/eUfi48WtX8IfRIHRX2Unr5TQfbu6JJY32
CjnhQnFPVG6nCDerJOnmXzsc+t52APNP9j+ok6cjOOAFqJLKe1ElOV/GzWP25j+d
PTiNEpUctEyxE3sXW22XePNXCTHPCvM4v7B4G3CVkhlHiKTKB7xIGmAOLyE+2cv5
/yqh1yWKhFNgioR6JOCG8VV7aMWPROeIPBfQ4yzjm8JB3oS0uXk=
=FN+n
-----END PGP SIGNATURE-----


_______________________________________________
Monotone-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/monotone-devel