Patch dolibarr 9.0.2 - allow accounts in "0"

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch dolibarr 9.0.2 - allow accounts in "0"

Eric Seigne
Hello all,

here is a patch for dolibarr 9.0.2 wich replace "empty" by "!= '' tests
againts fournisseurs accounts because i use "0" as prefix for theses
accounts.

i don't know if it could be used in official dolibarr sources ? if yes i
can make a pull request for that.

Éric

--
Éric Seigne             | CAP-REL*
[hidden email]  | +33 (0)6 987 444 01
https://cap-rel.fr      | *Réseau Expertise Linux


_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev

diff_dolibarr_9.0.2_officiel_et_cap_rel.patch (17K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Patch dolibarr 9.0.2 - allow accounts in "0"

Laurent Destailleur (aka Eldy)
If you want to avoid using git, you can still edit online the files with your modifications from your fork done on github and send the PR that github can generate for you.

Le mar. 23 avr. 2019 à 11:06, Eric Seigne <[hidden email]> a écrit :
Hello all,

here is a patch for dolibarr 9.0.2 wich replace "empty" by "!= '' tests
againts fournisseurs accounts because i use "0" as prefix for theses
accounts.

i don't know if it could be used in official dolibarr sources ? if yes i
can make a pull request for that.

Éric

--
Éric Seigne             | CAP-REL*
[hidden email]  | +33 (0)6 987 444 01
https://cap-rel.fr      | *Réseau Expertise Linux

_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev


--
------------------------------------------------------------------------------------
Google+: https://plus.google.com/+LaurentDestailleur-Open-Source-Expert/
Facebook: https://www.facebook.com/Destailleur.Laurent
------------------------------------------------------------------------------------
* Dolibarr (Project leader): https://www.dolibarr.org (make a donation for Dolibarr project via Paypal: [hidden email])
* AWStats (Author) : http://awstats.sourceforge.net (make a donation for AWStats project via Paypal: [hidden email])
* AWBot (Author) : http://awbot.sourceforge.net
* CVSChangeLogBuilder (Author) : http://cvschangelogb.sourceforge.net



_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
Reply | Threaded
Open this post in threaded view
|

Re: Patch dolibarr 9.0.2 - allow accounts in "0"

Eric Seigne

Hello all,

i'm sorry but i don't want to have and use a github account :-)

https://help.github.com/en/articles/github-terms-of-service#d-user-generated-content

https://help.github.com/en/articles/github-terms-of-service#f-copyright-infringement-and-dmca-policy

so i will do the job on something like https://framagit.org/public/projects for a next release ... i hope we can make PR from a gitlab instance to github ?

Éric

Le 14/05/2019 à 12:39, Laurent Destailleur (aka Eldy) a écrit :
If you want to avoid using git, you can still edit online the files with your modifications from your fork done on github and send the PR that github can generate for you.

Le mar. 23 avr. 2019 à 11:06, Eric Seigne <[hidden email]> a écrit :
Hello all,

here is a patch for dolibarr 9.0.2 wich replace "empty" by "!= '' tests
againts fournisseurs accounts because i use "0" as prefix for theses
accounts.

i don't know if it could be used in official dolibarr sources ? if yes i
can make a pull request for that.

Éric

--
Éric Seigne             | CAP-REL*
[hidden email]  | +33 (0)6 987 444 01
https://cap-rel.fr      | *Réseau Expertise Linux

_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev


--
------------------------------------------------------------------------------------
Google+: https://plus.google.com/+LaurentDestailleur-Open-Source-Expert/
Facebook: https://www.facebook.com/Destailleur.Laurent
------------------------------------------------------------------------------------
* Dolibarr (Project leader): https://www.dolibarr.org (make a donation for Dolibarr project via Paypal: [hidden email])
* AWStats (Author) : http://awstats.sourceforge.net (make a donation for AWStats project via Paypal: [hidden email])
* AWBot (Author) : http://awbot.sourceforge.net
* CVSChangeLogBuilder (Author) : http://cvschangelogb.sourceforge.net



_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
-- 
Éric Seigne             | CAP-REL*
[hidden email]  | +33 (0)6 987 444 01
https://cap-rel.fr      | *Réseau Expertise Linux

_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
Reply | Threaded
Open this post in threaded view
|

Re: Patch dolibarr 9.0.2 - allow accounts in "0"

Laurent Destailleur (aka Eldy)
We never tried this but it may be a good case to test this....

Le lun. 20 mai 2019 à 12:40, Eric Seigne <[hidden email]> a écrit :

Hello all,

i'm sorry but i don't want to have and use a github account :-)

https://help.github.com/en/articles/github-terms-of-service#d-user-generated-content

https://help.github.com/en/articles/github-terms-of-service#f-copyright-infringement-and-dmca-policy

so i will do the job on something like https://framagit.org/public/projects for a next release ... i hope we can make PR from a gitlab instance to github ?

Éric

Le 14/05/2019 à 12:39, Laurent Destailleur (aka Eldy) a écrit :
If you want to avoid using git, you can still edit online the files with your modifications from your fork done on github and send the PR that github can generate for you.

Le mar. 23 avr. 2019 à 11:06, Eric Seigne <[hidden email]> a écrit :
Hello all,

here is a patch for dolibarr 9.0.2 wich replace "empty" by "!= '' tests
againts fournisseurs accounts because i use "0" as prefix for theses
accounts.

i don't know if it could be used in official dolibarr sources ? if yes i
can make a pull request for that.

Éric

--
Éric Seigne             | CAP-REL*
[hidden email]  | +33 (0)6 987 444 01
https://cap-rel.fr      | *Réseau Expertise Linux

_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev


--
------------------------------------------------------------------------------------
Google+: https://plus.google.com/+LaurentDestailleur-Open-Source-Expert/
Facebook: https://www.facebook.com/Destailleur.Laurent
------------------------------------------------------------------------------------
* Dolibarr (Project leader): https://www.dolibarr.org (make a donation for Dolibarr project via Paypal: [hidden email])
* AWStats (Author) : http://awstats.sourceforge.net (make a donation for AWStats project via Paypal: [hidden email])
* AWBot (Author) : http://awbot.sourceforge.net
* CVSChangeLogBuilder (Author) : http://cvschangelogb.sourceforge.net



_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
-- 
Éric Seigne             | CAP-REL*
[hidden email]  | +33 (0)6 987 444 01
https://cap-rel.fr      | *Réseau Expertise Linux
_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev


--
------------------------------------------------------------------------------------
Google+: https://plus.google.com/+LaurentDestailleur-Open-Source-Expert/
Facebook: https://www.facebook.com/Destailleur.Laurent
------------------------------------------------------------------------------------
* Dolibarr (Project leader): https://www.dolibarr.org (make a donation for Dolibarr project via Paypal: [hidden email])
* AWStats (Author) : http://awstats.sourceforge.net (make a donation for AWStats project via Paypal: [hidden email])
* AWBot (Author) : http://awbot.sourceforge.net
* CVSChangeLogBuilder (Author) : http://cvschangelogb.sourceforge.net



_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
Reply | Threaded
Open this post in threaded view
|

Re: Patch dolibarr 9.0.2 - allow accounts in "0"

Sasa Ostrouska
Excuse me if I fall into this, but isnt it possible to do PR and apply
a simple patch simply with git ?
git diff should be enough to submit a patch to the ML for review and
then it is easy to apply if all is ok.

Just my 2 cents, why migrate everything to a gitlab or other portal ???

Rgds
Saxa

On Tue, Jun 11, 2019 at 6:57 PM Laurent Destailleur (aka Eldy)
<[hidden email]> wrote:

>
> We never tried this but it may be a good case to test this....
>
> Le lun. 20 mai 2019 à 12:40, Eric Seigne <[hidden email]> a écrit :
>>
>> Hello all,
>>
>> i'm sorry but i don't want to have and use a github account :-)
>>
>> https://help.github.com/en/articles/github-terms-of-service#d-user-generated-content
>>
>> https://help.github.com/en/articles/github-terms-of-service#f-copyright-infringement-and-dmca-policy
>>
>> so i will do the job on something like https://framagit.org/public/projects for a next release ... i hope we can make PR from a gitlab instance to github ?
>>
>> Éric
>>
>> Le 14/05/2019 à 12:39, Laurent Destailleur (aka Eldy) a écrit :
>>
>> If you want to avoid using git, you can still edit online the files with your modifications from your fork done on github and send the PR that github can generate for you.
>>
>> Le mar. 23 avr. 2019 à 11:06, Eric Seigne <[hidden email]> a écrit :
>>>
>>> Hello all,
>>>
>>> here is a patch for dolibarr 9.0.2 wich replace "empty" by "!= '' tests
>>> againts fournisseurs accounts because i use "0" as prefix for theses
>>> accounts.
>>>
>>> i don't know if it could be used in official dolibarr sources ? if yes i
>>> can make a pull request for that.
>>>
>>> Éric
>>>
>>> --
>>> Éric Seigne             | CAP-REL*
>>> [hidden email]  | +33 (0)6 987 444 01
>>> https://cap-rel.fr      | *Réseau Expertise Linux
>>>
>>> _______________________________________________
>>> Dolibarr-dev mailing list
>>> [hidden email]
>>> https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
>>
>>
>>
>> --
>> EMail: [hidden email]
>> Web: http://www.destailleur.fr
>> ------------------------------------------------------------------------------------
>> Google+: https://plus.google.com/+LaurentDestailleur-Open-Source-Expert/
>> Facebook: https://www.facebook.com/Destailleur.Laurent
>> Twitter: http://www.twitter.com/eldy10
>> ------------------------------------------------------------------------------------
>> * Dolibarr (Project leader): https://www.dolibarr.org (make a donation for Dolibarr project via Paypal: [hidden email])
>> * AWStats (Author) : http://awstats.sourceforge.net (make a donation for AWStats project via Paypal: [hidden email])
>> * AWBot (Author) : http://awbot.sourceforge.net
>> * CVSChangeLogBuilder (Author) : http://cvschangelogb.sourceforge.net
>>
>>
>>
>> _______________________________________________
>> Dolibarr-dev mailing list
>> [hidden email]
>> https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
>>
>> --
>> Éric Seigne             | CAP-REL*
>> [hidden email]  | +33 (0)6 987 444 01
>> https://cap-rel.fr      | *Réseau Expertise Linux
>>
>> _______________________________________________
>> Dolibarr-dev mailing list
>> [hidden email]
>> https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
>
>
>
> --
> EMail: [hidden email]
> Web: http://www.destailleur.fr
> ------------------------------------------------------------------------------------
> Google+: https://plus.google.com/+LaurentDestailleur-Open-Source-Expert/
> Facebook: https://www.facebook.com/Destailleur.Laurent
> Twitter: http://www.twitter.com/eldy10
> ------------------------------------------------------------------------------------
> * Dolibarr (Project leader): https://www.dolibarr.org (make a donation for Dolibarr project via Paypal: [hidden email])
> * AWStats (Author) : http://awstats.sourceforge.net (make a donation for AWStats project via Paypal: [hidden email])
> * AWBot (Author) : http://awbot.sourceforge.net
> * CVSChangeLogBuilder (Author) : http://cvschangelogb.sourceforge.net
>
>
> _______________________________________________
> Dolibarr-dev mailing list
> [hidden email]
> https://lists.nongnu.org/mailman/listinfo/dolibarr-dev

_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
Reply | Threaded
Open this post in threaded view
|

Re: Patch dolibarr 9.0.2 - allow accounts in "0"

Eric Seigne
In reply to this post by Laurent Destailleur (aka Eldy)

Ok,

sorry i've just re-activate an old account for that ... :-)

-> https://github.com/Dolibarr/dolibarr/pull/11354

Éric

Le 11/06/2019 à 18:10, Laurent Destailleur (aka Eldy) a écrit :
We never tried this but it may be a good case to test this....

Le lun. 20 mai 2019 à 12:40, Eric Seigne <[hidden email]> a écrit :

Hello all,

i'm sorry but i don't want to have and use a github account :-)

https://help.github.com/en/articles/github-terms-of-service#d-user-generated-content

https://help.github.com/en/articles/github-terms-of-service#f-copyright-infringement-and-dmca-policy

so i will do the job on something like https://framagit.org/public/projects for a next release ... i hope we can make PR from a gitlab instance to github ?

Éric

Le 14/05/2019 à 12:39, Laurent Destailleur (aka Eldy) a écrit :
If you want to avoid using git, you can still edit online the files with your modifications from your fork done on github and send the PR that github can generate for you.

Le mar. 23 avr. 2019 à 11:06, Eric Seigne <[hidden email]> a écrit :
Hello all,

here is a patch for dolibarr 9.0.2 wich replace "empty" by "!= '' tests
againts fournisseurs accounts because i use "0" as prefix for theses
accounts.

i don't know if it could be used in official dolibarr sources ? if yes i
can make a pull request for that.

Éric

--
Éric Seigne             | CAP-REL*
[hidden email]  | +33 (0)6 987 444 01
https://cap-rel.fr      | *Réseau Expertise Linux

_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev


--
------------------------------------------------------------------------------------
Google+: https://plus.google.com/+LaurentDestailleur-Open-Source-Expert/
Facebook: https://www.facebook.com/Destailleur.Laurent
------------------------------------------------------------------------------------
* Dolibarr (Project leader): https://www.dolibarr.org (make a donation for Dolibarr project via Paypal: [hidden email])
* AWStats (Author) : http://awstats.sourceforge.net (make a donation for AWStats project via Paypal: [hidden email])
* AWBot (Author) : http://awbot.sourceforge.net
* CVSChangeLogBuilder (Author) : http://cvschangelogb.sourceforge.net



_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
-- 
Éric Seigne             | CAP-REL*
[hidden email]  | +33 (0)6 987 444 01
https://cap-rel.fr      | *Réseau Expertise Linux
_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev


--
------------------------------------------------------------------------------------
Google+: https://plus.google.com/+LaurentDestailleur-Open-Source-Expert/
Facebook: https://www.facebook.com/Destailleur.Laurent
------------------------------------------------------------------------------------
* Dolibarr (Project leader): https://www.dolibarr.org (make a donation for Dolibarr project via Paypal: [hidden email])
* AWStats (Author) : http://awstats.sourceforge.net (make a donation for AWStats project via Paypal: [hidden email])
* AWBot (Author) : http://awbot.sourceforge.net
* CVSChangeLogBuilder (Author) : http://cvschangelogb.sourceforge.net



_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
-- 
Éric Seigne             | CAP-REL*
[hidden email]  | +33 (0)6 987 444 01
https://cap-rel.fr      | *Réseau Expertise Linux

_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev