Proposal: move glusterfs development to github workflow, completely

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
19 messages Options
Reply | Threaded
Open this post in threaded view
|

Proposal: move glusterfs development to github workflow, completely

Amar Tumballi-2
Hi developers,

With this email, I want to understand what is the general feeling around this topic.

We from gluster org (in github.com/gluster) have many projects which follow complete github workflow, where as there are few, specially the main one 'glusterfs', which uses 'Gerrit'.

While this has worked all these years, currently, there is a huge set of brain-share on github workflow as many other top projects, and similar projects use only github as the place to develop, track and run tests etc. As it is possible to have all of the tools required for this project in github itself (code, PR, issues, CI/CD, docs), lets look at how we are structured today:

Gerrit - glusterfs code + Review system
Bugzilla - For bugs
Github - For feature requests
Trello - (not very much used) for tracking project development.
CI/CD - CentOS-ci / Jenkins, etc but maintained from different repo.
Docs - glusterdocs - different repo.
Metrics - Nothing (other than github itself tracking contributors).

While it may cause a minor glitch for many long time developers who are used to the flow, moving to github would bring all these in single place, makes getting new users easy, and uniform development practices for all gluster org repositories.

As it is just the proposal, I would like to hear people's thought on this, and conclude on this another month, so by glusterfs-8 development time, we are clear about this.

Can we decide on this before September 30th? Please voice your concerns.

Regards,
Amar




_______________________________________________

Community Meeting Calendar:

APAC Schedule -
Every 2nd and 4th Tuesday at 11:30 AM IST
Bridge: https://bluejeans.com/836554017

NA/EMEA Schedule -
Every 1st and 3rd Tuesday at 01:00 PM EDT
Bridge: https://bluejeans.com/486278655

Gluster-devel mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/gluster-devel

Reply | Threaded
Open this post in threaded view
|

Re: Proposal: move glusterfs development to github workflow, completely

Yaniv Kaul


On Fri, 23 Aug 2019, 9:13 Amar Tumballi <[hidden email]> wrote:
Hi developers,

With this email, I want to understand what is the general feeling around this topic.

We from gluster org (in github.com/gluster) have many projects which follow complete github workflow, where as there are few, specially the main one 'glusterfs', which uses 'Gerrit'.

While this has worked all these years, currently, there is a huge set of brain-share on github workflow as many other top projects, and similar projects use only github as the place to develop, track and run tests etc. As it is possible to have all of the tools required for this project in github itself (code, PR, issues, CI/CD, docs), lets look at how we are structured today:

Gerrit - glusterfs code + Review system
Bugzilla - For bugs
Github - For feature requests
Trello - (not very much used) for tracking project development.
CI/CD - CentOS-ci / Jenkins, etc but maintained from different repo.
Docs - glusterdocs - different repo.
Metrics - Nothing (other than github itself tracking contributors).

While it may cause a minor glitch for many long time developers who are used to the flow, moving to github would bring all these in single place, makes getting new users easy, and uniform development practices for all gluster org repositories.

As it is just the proposal, I would like to hear people's thought on this, and conclude on this another month, so by glusterfs-8 development time, we are clear about this.

I don't like mixed mode, but I also dislike Github's code review tools, so I'd like to remind the option of using http://gerrithub.io/ for code review. 
Other than that, I'm in favor of moving over. 
Y. 


Can we decide on this before September 30th? Please voice your concerns.

Regards,
Amar



_______________________________________________

Community Meeting Calendar:

APAC Schedule -
Every 2nd and 4th Tuesday at 11:30 AM IST
Bridge: https://bluejeans.com/836554017

NA/EMEA Schedule -
Every 1st and 3rd Tuesday at 01:00 PM EDT
Bridge: https://bluejeans.com/486278655

Gluster-devel mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/gluster-devel


_______________________________________________

Community Meeting Calendar:

APAC Schedule -
Every 2nd and 4th Tuesday at 11:30 AM IST
Bridge: https://bluejeans.com/836554017

NA/EMEA Schedule -
Every 1st and 3rd Tuesday at 01:00 PM EDT
Bridge: https://bluejeans.com/486278655

Gluster-devel mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/gluster-devel

Reply | Threaded
Open this post in threaded view
|

Re: [Gluster-Maintainers] Proposal: move glusterfs development to github workflow, completely

Sankarshan Mukhopadhyay
In reply to this post by Amar Tumballi-2
On Fri, Aug 23, 2019 at 6:42 PM Amar Tumballi <[hidden email]> wrote:

>
> Hi developers,
>
> With this email, I want to understand what is the general feeling around this topic.
>
> We from gluster org (in github.com/gluster) have many projects which follow complete github workflow, where as there are few, specially the main one 'glusterfs', which uses 'Gerrit'.
>
> While this has worked all these years, currently, there is a huge set of brain-share on github workflow as many other top projects, and similar projects use only github as the place to develop, track and run tests etc. As it is possible to have all of the tools required for this project in github itself (code, PR, issues, CI/CD, docs), lets look at how we are structured today:
>
> Gerrit - glusterfs code + Review system
> Bugzilla - For bugs
> Github - For feature requests
> Trello - (not very much used) for tracking project development.
> CI/CD - CentOS-ci / Jenkins, etc but maintained from different repo.
> Docs - glusterdocs - different repo.
> Metrics - Nothing (other than github itself tracking contributors).
>
> While it may cause a minor glitch for many long time developers who are used to the flow, moving to github would bring all these in single place, makes getting new users easy, and uniform development practices for all gluster org repositories.
>
> As it is just the proposal, I would like to hear people's thought on this, and conclude on this another month, so by glusterfs-8 development time, we are clear about this.
>

I'd want to propose that a decision be arrived at much earlier. Say,
within a fortnight ie. mid-Sep. I do not see why this would need a
whole month to consider. Such a timeline would also allow to manage
changes after proper assessment of sub-tasks.

> Can we decide on this before September 30th? Please voice your concerns.
>
> Regards,
> Amar
_______________________________________________

Community Meeting Calendar:

APAC Schedule -
Every 2nd and 4th Tuesday at 11:30 AM IST
Bridge: https://bluejeans.com/836554017

NA/EMEA Schedule -
Every 1st and 3rd Tuesday at 01:00 PM EDT
Bridge: https://bluejeans.com/486278655

Gluster-devel mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/gluster-devel

Reply | Threaded
Open this post in threaded view
|

Re: [Gluster-Maintainers] Proposal: move glusterfs development to github workflow, completely

Raghavendra Talur-2
In reply to this post by Amar Tumballi-2


On Fri, Aug 23, 2019, 9:12 AM Amar Tumballi <[hidden email]> wrote:
Hi developers,

With this email, I want to understand what is the general feeling around this topic.

We from gluster org (in github.com/gluster) have many projects which follow complete github workflow, where as there are few, specially the main one 'glusterfs', which uses 'Gerrit'.

While this has worked all these years, currently, there is a huge set of brain-share on github workflow as many other top projects, and similar projects use only github as the place to develop, track and run tests etc. As it is possible to have all of the tools required for this project in github itself (code, PR, issues, CI/CD, docs), lets look at how we are structured today:

Gerrit - glusterfs code + Review system
Bugzilla - For bugs
Github - For feature requests
Trello - (not very much used) for tracking project development.
CI/CD - CentOS-ci / Jenkins, etc but maintained from different repo.
Docs - glusterdocs - different repo.
Metrics - Nothing (other than github itself tracking contributors).

While it may cause a minor glitch for many long time developers who are used to the flow, moving to github would bring all these in single place, makes getting new users easy, and uniform development practices for all gluster org repositories.

As it is just the proposal, I would like to hear people's thought on this, and conclude on this another month, so by glusterfs-8 development time, we are clear about this.

A huge +1 to this proposal. As you said, github has wider mind share and new developers won't have to learn tooling to contribute to gluster. 

Thanks 
Raghavendra Talur 

Can we decide on this before September 30th? Please voice your concerns.

Regards,
Amar



_______________________________________________
maintainers mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/maintainers

_______________________________________________

Community Meeting Calendar:

APAC Schedule -
Every 2nd and 4th Tuesday at 11:30 AM IST
Bridge: https://bluejeans.com/836554017

NA/EMEA Schedule -
Every 1st and 3rd Tuesday at 01:00 PM EDT
Bridge: https://bluejeans.com/486278655

Gluster-devel mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/gluster-devel

Reply | Threaded
Open this post in threaded view
|

Re: [Gluster-Maintainers] Proposal: move glusterfs development to github workflow, completely

Amar Tumballi-2
In reply to this post by Sankarshan Mukhopadhyay


On Sat, Aug 24, 2019 at 4:33 PM Sankarshan Mukhopadhyay <[hidden email]> wrote:
On Fri, Aug 23, 2019 at 6:42 PM Amar Tumballi <[hidden email]> wrote:
>
> Hi developers,
>
> With this email, I want to understand what is the general feeling around this topic.
>
> We from gluster org (in github.com/gluster) have many projects which follow complete github workflow, where as there are few, specially the main one 'glusterfs', which uses 'Gerrit'.
>
> While this has worked all these years, currently, there is a huge set of brain-share on github workflow as many other top projects, and similar projects use only github as the place to develop, track and run tests etc. As it is possible to have all of the tools required for this project in github itself (code, PR, issues, CI/CD, docs), lets look at how we are structured today:
>
> Gerrit - glusterfs code + Review system
> Bugzilla - For bugs
> Github - For feature requests
> Trello - (not very much used) for tracking project development.
> CI/CD - CentOS-ci / Jenkins, etc but maintained from different repo.
> Docs - glusterdocs - different repo.
> Metrics - Nothing (other than github itself tracking contributors).
>
> While it may cause a minor glitch for many long time developers who are used to the flow, moving to github would bring all these in single place, makes getting new users easy, and uniform development practices for all gluster org repositories.
>
> As it is just the proposal, I would like to hear people's thought on this, and conclude on this another month, so by glusterfs-8 development time, we are clear about this.
>

I'd want to propose that a decision be arrived at much earlier. Say,
within a fortnight ie. mid-Sep. I do not see why this would need a
whole month to consider. Such a timeline would also allow to manage
changes after proper assessment of sub-tasks.


It would be great if we can decide sooner. I kept a month as timeline, as historically, I had not seen much responses to proposal like this. Would be great if we have at least 20+ people participating in this discussion.

I am happy to create a poll if everyone prefers that.

Regards,
Amar
 
> Can we decide on this before September 30th? Please voice your concerns.
>
> Regards,
> Amar
_______________________________________________

Community Meeting Calendar:

APAC Schedule -
Every 2nd and 4th Tuesday at 11:30 AM IST
Bridge: https://bluejeans.com/836554017

NA/EMEA Schedule -
Every 1st and 3rd Tuesday at 01:00 PM EDT
Bridge: https://bluejeans.com/486278655

Gluster-devel mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/gluster-devel


_______________________________________________

Community Meeting Calendar:

APAC Schedule -
Every 2nd and 4th Tuesday at 11:30 AM IST
Bridge: https://bluejeans.com/836554017

NA/EMEA Schedule -
Every 1st and 3rd Tuesday at 01:00 PM EDT
Bridge: https://bluejeans.com/486278655

Gluster-devel mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/gluster-devel

Reply | Threaded
Open this post in threaded view
|

Re: [Gluster-Maintainers] Proposal: move glusterfs development to github workflow, completely

Vijay Bellur-4
In reply to this post by Amar Tumballi-2


On Fri, Aug 23, 2019 at 6:12 AM Amar Tumballi <[hidden email]> wrote:
Hi developers,

With this email, I want to understand what is the general feeling around this topic.

We from gluster org (in github.com/gluster) have many projects which follow complete github workflow, where as there are few, specially the main one 'glusterfs', which uses 'Gerrit'.

While this has worked all these years, currently, there is a huge set of brain-share on github workflow as many other top projects, and similar projects use only github as the place to develop, track and run tests etc. As it is possible to have all of the tools required for this project in github itself (code, PR, issues, CI/CD, docs), lets look at how we are structured today:

Gerrit - glusterfs code + Review system
Bugzilla - For bugs
Github - For feature requests
Trello - (not very much used) for tracking project development.
CI/CD - CentOS-ci / Jenkins, etc but maintained from different repo.
Docs - glusterdocs - different repo.
Metrics - Nothing (other than github itself tracking contributors).

While it may cause a minor glitch for many long time developers who are used to the flow, moving to github would bring all these in single place, makes getting new users easy, and uniform development practices for all gluster org repositories.

As it is just the proposal, I would like to hear people's thought on this, and conclude on this another month, so by glusterfs-8 development time, we are clear about this.


+1 to the idea.

While we are at this, any more thoughts about consolidating IRC/Slack/gitter etc.?

Thanks,
Vijay

_______________________________________________

Community Meeting Calendar:

APAC Schedule -
Every 2nd and 4th Tuesday at 11:30 AM IST
Bridge: https://bluejeans.com/836554017

NA/EMEA Schedule -
Every 1st and 3rd Tuesday at 01:00 PM EDT
Bridge: https://bluejeans.com/486278655

Gluster-devel mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/gluster-devel

Reply | Threaded
Open this post in threaded view
|

Re: Proposal: move glusterfs development to github workflow, completely

Ravishankar N
In reply to this post by Yaniv Kaul

On 24/08/19 9:26 AM, Yaniv Kaul wrote:
> I don't like mixed mode, but I also dislike Github's code review
> tools, so I'd like to remind the option of using http://gerrithub.io/ 
> for code review.
> Other than that, I'm in favor of moving over.
> Y.
+1 for using gerrithub for code review when we move to github.
_______________________________________________

Community Meeting Calendar:

APAC Schedule -
Every 2nd and 4th Tuesday at 11:30 AM IST
Bridge: https://bluejeans.com/836554017

NA/EMEA Schedule -
Every 1st and 3rd Tuesday at 01:00 PM EDT
Bridge: https://bluejeans.com/486278655

Gluster-devel mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/gluster-devel

Reply | Threaded
Open this post in threaded view
|

Re: Proposal: move glusterfs development to github workflow, completely

Barak Sason Rofman
Greetings all,

As a new developer on the project, I might add a fresh look on the matter.

Before I can here I was familiar with Github and unfamiliar with Gerrit.
Understanding Gerrit itself wasn't too troublesome, but also not needed as I see no benefit of using that system, because as others suggested, solutions like Gerrithub exist.
In general centralized workflow is always welcomed and personally I'd be happy to make the switch.
+1 for me.

On Mon, Aug 26, 2019 at 10:06 AM Ravishankar N <[hidden email]> wrote:

On 24/08/19 9:26 AM, Yaniv Kaul wrote:
> I don't like mixed mode, but I also dislike Github's code review
> tools, so I'd like to remind the option of using http://gerrithub.io/
> for code review.
> Other than that, I'm in favor of moving over.
> Y.
+1 for using gerrithub for code review when we move to github.
_______________________________________________

Community Meeting Calendar:

APAC Schedule -
Every 2nd and 4th Tuesday at 11:30 AM IST
Bridge: https://bluejeans.com/836554017

NA/EMEA Schedule -
Every 1st and 3rd Tuesday at 01:00 PM EDT
Bridge: https://bluejeans.com/486278655

Gluster-devel mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/gluster-devel



--
Barak Sason Rofman

Gluster Storage Development

Red Hat Israel

34 Jerusalem rd. Ra'anana, 43501

bsasonro[hidden email]    T: +972-9-7692304
M: +972-52-4326355


_______________________________________________

Community Meeting Calendar:

APAC Schedule -
Every 2nd and 4th Tuesday at 11:30 AM IST
Bridge: https://bluejeans.com/836554017

NA/EMEA Schedule -
Every 1st and 3rd Tuesday at 01:00 PM EDT
Bridge: https://bluejeans.com/486278655

Gluster-devel mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/gluster-devel

Reply | Threaded
Open this post in threaded view
|

Re: [Gluster-Maintainers] Proposal: move glusterfs development to github workflow, completely

Niels de Vos-5
In reply to this post by Yaniv Kaul
On Fri, Aug 23, 2019 at 11:56:53PM -0400, Yaniv Kaul wrote:

> On Fri, 23 Aug 2019, 9:13 Amar Tumballi <[hidden email]> wrote:
>
> > Hi developers,
> >
> > With this email, I want to understand what is the general feeling around
> > this topic.
> >
> > We from gluster org (in github.com/gluster) have many projects which
> > follow complete github workflow, where as there are few, specially the main
> > one 'glusterfs', which uses 'Gerrit'.
> >
> > While this has worked all these years, currently, there is a huge set of
> > brain-share on github workflow as many other top projects, and similar
> > projects use only github as the place to develop, track and run tests etc.
> > As it is possible to have all of the tools required for this project in
> > github itself (code, PR, issues, CI/CD, docs), lets look at how we are
> > structured today:
> >
> > Gerrit - glusterfs code + Review system
> > Bugzilla - For bugs
> > Github - For feature requests
> > Trello - (not very much used) for tracking project development.
> > CI/CD - CentOS-ci / Jenkins, etc but maintained from different repo.
> > Docs - glusterdocs - different repo.
> > Metrics - Nothing (other than github itself tracking contributors).
> >
> > While it may cause a minor glitch for many long time developers who are
> > used to the flow, moving to github would bring all these in single place,
> > makes getting new users easy, and uniform development practices for all
> > gluster org repositories.
> >
> > As it is just the proposal, I would like to hear people's thought on this,
> > and conclude on this another month, so by glusterfs-8 development time, we
> > are clear about this.
> >
>
> I don't like mixed mode, but I also dislike Github's code review tools, so
> I'd like to remind the option of using http://gerrithub.io/ for code
> review.
> Other than that, I'm in favor of moving over.
> Y.

I agree that using GitHub for code review is not optimal. We have many
patches for the GlusterFS project that need multiple rounds of review
and corrections. Comparing the changes between revisions is something
that GitHub does not support, but Gerrit/GerritHub does.

Before switching over, there also needs to be documentation how to
structure the issues in GitHubs tracker (which labels to use, what they
mean etc,). Also, what about migration of bugs from Bugzilla to GitHub?

Except for those topics, I don't have a problem with moving to GitHub.

Niels
_______________________________________________

Community Meeting Calendar:

APAC Schedule -
Every 2nd and 4th Tuesday at 11:30 AM IST
Bridge: https://bluejeans.com/836554017

NA/EMEA Schedule -
Every 1st and 3rd Tuesday at 01:00 PM EDT
Bridge: https://bluejeans.com/486278655

Gluster-devel mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/gluster-devel

Reply | Threaded
Open this post in threaded view
|

Re: [Gluster-Maintainers] Proposal: move glusterfs development to github workflow, completely

Joe Julian
> Comparing the changes between revisions is something
that GitHub does not support...

It does support that, actually.
_______________________________________________

Community Meeting Calendar:

APAC Schedule -
Every 2nd and 4th Tuesday at 11:30 AM IST
Bridge: https://bluejeans.com/836554017

NA/EMEA Schedule -
Every 1st and 3rd Tuesday at 01:00 PM EDT
Bridge: https://bluejeans.com/486278655

Gluster-devel mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/gluster-devel

Reply | Threaded
Open this post in threaded view
|

Re: [Gluster-Maintainers] Proposal: move glusterfs development to github workflow, completely

Aravinda Vishwanathapura Krishna Murthy


On Mon, Aug 26, 2019 at 7:49 PM Joe Julian <[hidden email]> wrote:
> Comparing the changes between revisions is something
that GitHub does not support...

It does support that, actually._______________________________________________

Yes, it does support. We need to use Squash merge after all review is done.
A sample pull request is here to see reviews with multiple revisions.



 
maintainers mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/maintainers


--
regards
Aravinda VK

_______________________________________________

Community Meeting Calendar:

APAC Schedule -
Every 2nd and 4th Tuesday at 11:30 AM IST
Bridge: https://bluejeans.com/836554017

NA/EMEA Schedule -
Every 1st and 3rd Tuesday at 01:00 PM EDT
Bridge: https://bluejeans.com/486278655

Gluster-devel mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/gluster-devel

Reply | Threaded
Open this post in threaded view
|

Re: [Gluster-Maintainers] Proposal: move glusterfs development to github workflow, completely

Joe Julian
You can also see diffs between force pushes now.

On August 26, 2019 8:06:30 AM PDT, Aravinda Vishwanathapura Krishna Murthy <[hidden email]> wrote:


On Mon, Aug 26, 2019 at 7:49 PM Joe Julian <[hidden email]> wrote:
> Comparing the changes between revisions is something
that GitHub does not support...

It does support that, actually._______________________________________________

Yes, it does support. We need to use Squash merge after all review is done.
A sample pull request is here to see reviews with multiple revisions.



 
maintainers mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/maintainers


--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
_______________________________________________

Community Meeting Calendar:

APAC Schedule -
Every 2nd and 4th Tuesday at 11:30 AM IST
Bridge: https://bluejeans.com/836554017

NA/EMEA Schedule -
Every 1st and 3rd Tuesday at 01:00 PM EDT
Bridge: https://bluejeans.com/486278655

Gluster-devel mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/gluster-devel

Reply | Threaded
Open this post in threaded view
|

Re: [Gluster-Maintainers] Proposal: move glusterfs development to github workflow, completely

Aravinda Vishwanathapura Krishna Murthy


On Mon, Aug 26, 2019 at 8:44 PM Joe Julian <[hidden email]> wrote:
You can also see diffs between force pushes now.

Nice.


On August 26, 2019 8:06:30 AM PDT, Aravinda Vishwanathapura Krishna Murthy <[hidden email]> wrote:


On Mon, Aug 26, 2019 at 7:49 PM Joe Julian <[hidden email]> wrote:
> Comparing the changes between revisions is something
that GitHub does not support...

It does support that, actually._______________________________________________

Yes, it does support. We need to use Squash merge after all review is done.
A sample pull request is here to see reviews with multiple revisions.



 
maintainers mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/maintainers


--
Sent from my Android device with K-9 Mail. Please excuse my brevity.


--
regards
Aravinda VK

_______________________________________________

Community Meeting Calendar:

APAC Schedule -
Every 2nd and 4th Tuesday at 11:30 AM IST
Bridge: https://bluejeans.com/836554017

NA/EMEA Schedule -
Every 1st and 3rd Tuesday at 01:00 PM EDT
Bridge: https://bluejeans.com/486278655

Gluster-devel mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/gluster-devel

Reply | Threaded
Open this post in threaded view
|

Re: [Gluster-Maintainers] Proposal: move glusterfs development to github workflow, completely

Niels de Vos-5
In reply to this post by Aravinda Vishwanathapura Krishna Murthy
On Mon, Aug 26, 2019 at 08:36:30PM +0530, Aravinda Vishwanathapura Krishna Murthy wrote:

> On Mon, Aug 26, 2019 at 7:49 PM Joe Julian <[hidden email]> wrote:
>
> > > Comparing the changes between revisions is something
> > that GitHub does not support...
> >
> > It does support that,
> > actually._______________________________________________
> >
>
> Yes, it does support. We need to use Squash merge after all review is done.

Squash merge would also combine multiple commits that are intended to
stay separate. This is really bad :-(

Niels
_______________________________________________

Community Meeting Calendar:

APAC Schedule -
Every 2nd and 4th Tuesday at 11:30 AM IST
Bridge: https://bluejeans.com/836554017

NA/EMEA Schedule -
Every 1st and 3rd Tuesday at 01:00 PM EDT
Bridge: https://bluejeans.com/486278655

Gluster-devel mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/gluster-devel

Reply | Threaded
Open this post in threaded view
|

Re: [Gluster-Maintainers] Proposal: move glusterfs development to github workflow, completely

Niels de Vos-5
In reply to this post by Joe Julian
On Mon, Aug 26, 2019 at 08:08:36AM -0700, Joe Julian wrote:
> You can also see diffs between force pushes now.

That is great! It is the feature that I was looking for. I have not
noticed it yet, will pay attention to it while working on other
projects.

Thanks,
Niels
_______________________________________________

Community Meeting Calendar:

APAC Schedule -
Every 2nd and 4th Tuesday at 11:30 AM IST
Bridge: https://bluejeans.com/836554017

NA/EMEA Schedule -
Every 1st and 3rd Tuesday at 01:00 PM EDT
Bridge: https://bluejeans.com/486278655

Gluster-devel mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/gluster-devel

Reply | Threaded
Open this post in threaded view
|

Re: [Gluster-Maintainers] Proposal: move glusterfs development to github workflow, completely

FNU Raghavendra Manjunath

+1 to the idea.

On Mon, Aug 26, 2019 at 2:41 PM Niels de Vos <[hidden email]> wrote:
On Mon, Aug 26, 2019 at 08:08:36AM -0700, Joe Julian wrote:
> You can also see diffs between force pushes now.

That is great! It is the feature that I was looking for. I have not
noticed it yet, will pay attention to it while working on other
projects.

Thanks,
Niels
_______________________________________________

Community Meeting Calendar:

APAC Schedule -
Every 2nd and 4th Tuesday at 11:30 AM IST
Bridge: https://bluejeans.com/836554017

NA/EMEA Schedule -
Every 1st and 3rd Tuesday at 01:00 PM EDT
Bridge: https://bluejeans.com/486278655

Gluster-devel mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/gluster-devel


_______________________________________________

Community Meeting Calendar:

APAC Schedule -
Every 2nd and 4th Tuesday at 11:30 AM IST
Bridge: https://bluejeans.com/836554017

NA/EMEA Schedule -
Every 1st and 3rd Tuesday at 01:00 PM EDT
Bridge: https://bluejeans.com/486278655

Gluster-devel mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/gluster-devel

Reply | Threaded
Open this post in threaded view
|

Re: [Gluster-Maintainers] Proposal: move glusterfs development to github workflow, completely

Amar Tumballi Suryanarayan
In reply to this post by Niels de Vos-5


On Tue, Aug 27, 2019 at 12:10 AM Niels de Vos <[hidden email]> wrote:
On Mon, Aug 26, 2019 at 08:36:30PM +0530, Aravinda Vishwanathapura Krishna Murthy wrote:
> On Mon, Aug 26, 2019 at 7:49 PM Joe Julian <[hidden email]> wrote:
>
> > > Comparing the changes between revisions is something
> > that GitHub does not support...
> >
> > It does support that,
> > actually._______________________________________________
> >
>
> Yes, it does support. We need to use Squash merge after all review is done.

Squash merge would also combine multiple commits that are intended to
stay separate. This is really bad :-(


We should treat 1 patch in gerrit as 1 PR in github, then squash merge works same as how reviews in gerrit are done.  Or we can come up with label, upon which we can actually do 'rebase and merge' option, which can preserve the commits as is.

-Amar
 
Niels
_______________________________________________
maintainers mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/maintainers


--
Amar Tumballi (amarts)

_______________________________________________

Community Meeting Calendar:

APAC Schedule -
Every 2nd and 4th Tuesday at 11:30 AM IST
Bridge: https://bluejeans.com/836554017

NA/EMEA Schedule -
Every 1st and 3rd Tuesday at 01:00 PM EDT
Bridge: https://bluejeans.com/486278655

Gluster-devel mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/gluster-devel

Reply | Threaded
Open this post in threaded view
|

Re: [Gluster-Maintainers] Proposal: move glusterfs development to github workflow, completely

Niels de Vos-5
On Tue, Aug 27, 2019 at 06:57:14AM +0530, Amar Tumballi Suryanarayan wrote:

> On Tue, Aug 27, 2019 at 12:10 AM Niels de Vos <[hidden email]> wrote:
>
> > On Mon, Aug 26, 2019 at 08:36:30PM +0530, Aravinda Vishwanathapura Krishna
> > Murthy wrote:
> > > On Mon, Aug 26, 2019 at 7:49 PM Joe Julian <[hidden email]> wrote:
> > >
> > > > > Comparing the changes between revisions is something
> > > > that GitHub does not support...
> > > >
> > > > It does support that,
> > > > actually._______________________________________________
> > > >
> > >
> > > Yes, it does support. We need to use Squash merge after all review is
> > done.
> >
> > Squash merge would also combine multiple commits that are intended to
> > stay separate. This is really bad :-(
> >
> >
> We should treat 1 patch in gerrit as 1 PR in github, then squash merge
> works same as how reviews in gerrit are done.  Or we can come up with
> label, upon which we can actually do 'rebase and merge' option, which can
> preserve the commits as is.

Something like that would be good. For many things, including commit
message update squashing patches is just loosing details. We dont do
that with Gerrit now, and we should not do that when using GitHub PRs.
Proper documenting changes is still very important to me, the details of
patches should be explained in commit messages. This only works well
when developers 'force push' to the branch holding the PR.

Niels
_______________________________________________

Community Meeting Calendar:

APAC Schedule -
Every 2nd and 4th Tuesday at 11:30 AM IST
Bridge: https://bluejeans.com/836554017

NA/EMEA Schedule -
Every 1st and 3rd Tuesday at 01:00 PM EDT
Bridge: https://bluejeans.com/486278655

Gluster-devel mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/gluster-devel

Reply | Threaded
Open this post in threaded view
|

Re: [Gluster-Maintainers] Proposal: move glusterfs development to github workflow, completely

Amar Tumballi-2
Going through the thread, I see in general positive responses for the same, with few points on review system, and not loosing information when merging the patches.

While we are working on that, we need to see and understand how our CI/CD looks like with github migration. We surely need suggestion and volunteers here to get this going.

Regards,
Amar


On Wed, Aug 28, 2019 at 12:38 PM Niels de Vos <[hidden email]> wrote:
On Tue, Aug 27, 2019 at 06:57:14AM +0530, Amar Tumballi Suryanarayan wrote:
> On Tue, Aug 27, 2019 at 12:10 AM Niels de Vos <[hidden email]> wrote:
>
> > On Mon, Aug 26, 2019 at 08:36:30PM +0530, Aravinda Vishwanathapura Krishna
> > Murthy wrote:
> > > On Mon, Aug 26, 2019 at 7:49 PM Joe Julian <[hidden email]> wrote:
> > >
> > > > > Comparing the changes between revisions is something
> > > > that GitHub does not support...
> > > >
> > > > It does support that,
> > > > actually._______________________________________________
> > > >
> > >
> > > Yes, it does support. We need to use Squash merge after all review is
> > done.
> >
> > Squash merge would also combine multiple commits that are intended to
> > stay separate. This is really bad :-(
> >
> >
> We should treat 1 patch in gerrit as 1 PR in github, then squash merge
> works same as how reviews in gerrit are done.  Or we can come up with
> label, upon which we can actually do 'rebase and merge' option, which can
> preserve the commits as is.

Something like that would be good. For many things, including commit
message update squashing patches is just loosing details. We dont do
that with Gerrit now, and we should not do that when using GitHub PRs.
Proper documenting changes is still very important to me, the details of
patches should be explained in commit messages. This only works well
when developers 'force push' to the branch holding the PR.

Niels
_______________________________________________

Community Meeting Calendar:

APAC Schedule -
Every 2nd and 4th Tuesday at 11:30 AM IST
Bridge: https://bluejeans.com/836554017

NA/EMEA Schedule -
Every 1st and 3rd Tuesday at 01:00 PM EDT
Bridge: https://bluejeans.com/486278655

Gluster-devel mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/gluster-devel


_______________________________________________

Community Meeting Calendar:

APAC Schedule -
Every 2nd and 4th Tuesday at 11:30 AM IST
Bridge: https://bluejeans.com/836554017

NA/EMEA Schedule -
Every 1st and 3rd Tuesday at 01:00 PM EDT
Bridge: https://bluejeans.com/486278655

Gluster-devel mailing list
[hidden email]
https://lists.gluster.org/mailman/listinfo/gluster-devel