Re: Re: SKS, Content-Length and HEAD requests

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Re: SKS, Content-Length and HEAD requests

Marian Kechlibar
(I have, by mistake, sent the message only to the author. Resending it to the conference...)

Dear Phil,

the modification with limit is good. This could be easy and
straightforward.

I would still very much like Content-Length to be present in the header.
This makes things so much easier on a slow network.

Best regards

Marian


_______________________________________________
Sks-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/sks-devel
Reply | Threaded
Open this post in threaded view
|

Re: Re: SKS, Content-Length and HEAD requests

Johan van Selst
Marian Kechlibar wrote:
> the modification with limit is good. This could be easy and
> straightforward.
> I would still very much like Content-Length to be present in the header.
> This makes things so much easier on a slow network.

This should be simple enough to add. Something like the patch below
might do the trick.


Johan

--- a/wserver.ml 2010-11-02 22:52:40.766457000 +0100
+++ b/wserver.ml 2010-11-02 22:54:47.593314000 +0100
@@ -239,6 +239,7 @@
 let send_result cout ?(error_code = 200) ?(content_type = "text/html; charset=UTF-8") body =
   fprintf cout "HTTP/1.0 %03d OK\r\n" error_code;
   fprintf cout "Server: sks_www/%s\r\n" version;
+  fprintf cout "Content-length: %u\r\n" (String.length body + 2);
   fprintf cout "Content-type: %s\r\n\r\n" content_type;
   fprintf cout "%s\r\n" body;
   flush cout

_______________________________________________
Sks-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/sks-devel

attachment0 (201 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: SKS, Content-Length and HEAD requests

Marian Kechlibar

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
 
If the patch is so simple, I would believe that adding HEAD
functionality would be very similarly simple ...?

Best regards

MK

Dne 2.11.2010 22:57, Johan van Selst napsal(a):

> Marian Kechlibar wrote:
>> the modification with limit is good. This could be easy and
>> straightforward. I would still very much like Content-Length to
>> be present in the header. This makes things so much easier on a
>> slow network.
>
> This should be simple enough to add. Something like the patch
> below might do the trick.
>
>
> Johan
>
> --- a/wserver.ml 2010-11-02 22:52:40.766457000 +0100 +++
> b/wserver.ml 2010-11-02 22:54:47.593314000 +0100 @@ -239,6 +239,7
> @@ let send_result cout ?(error_code = 200) ?(content_type =
> "text/html; charset=UTF-8") body = fprintf cout "HTTP/1.0 %03d
> OK\r\n" error_code; fprintf cout "Server: sks_www/%s\r\n" version;
> + fprintf cout "Content-length: %u\r\n" (String.length body + 2);
> fprintf cout "Content-type: %s\r\n\r\n" content_type; fprintf cout
> "%s\r\n" body; flush cout

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
 
iQIcBAEBAgAGBQJM0I7VAAoJEOJiGpwt9DuCpLcP/3jM+Z60vgWUxKILIkntgm57
UkLCKN8GUMRUaK9qT2caWwNMDghDYeSqGwglJOzU7SS2lN/egichw62Qg/CkwoYK
Ek4ahCajtvYRNHvK8LhN3koZp7Rt4T7vzFxs0K5A8xfbXXxJ0i3LS52xztABDAhO
2fiHAhQKIKRjpMHRZTHmsXMnD3Q831mRprm0lww04JID3hVQZih/sfxhXMeZ6WTy
vE9KpdB8gkJG+Q5ImOw/cVP5BXbTAiQAnmyZbpf5x9Q9fMmBp3mV4iBI8wthv2dc
951LNFWWFgBVd7S+eJv9oQFrsfMitOb9cXrCLV8YVv86ODFv0gXMtcmI8yjPyoUR
Ijluf+ZLEQ4959IXf9QjCt9WEPsGXNZNhVzI2V0WPphfIg0qgHa/Ln4fWi1xlDJG
tDcAeh5RkGdljA9LxkNxw0S1kIxVaYr7iM9H6vUSW95LeEjwZFdmMQRrAxe3LNEJ
RgfO9s4jDqS20NsbbmSLxC2sJMlG+lIM8+iFtPKBxBSmcAutM0bkKW+KWUPkijgp
H0+MTsQlKFzlIPmz/zhp95alPa88x5aErF1ybZf0eDFtVeXFAuObPMaRx2Loeha/
7/26VGkOPumLsiSyy4jZxAeMbAzZG7FieDP5sktt9lKRYHEKGYUJa3bDouk2GFxX
1rmaaEOgPocIbb/qtnPB
=E4Fz
-----END PGP SIGNATURE-----


_______________________________________________
Sks-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/sks-devel
Reply | Threaded
Open this post in threaded view
|

Re: SKS, Content-Length and HEAD requests

Marian Kechlibar
In reply to this post by Johan van Selst

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
 
Would anybody here be willing to add Johan's Content-Length patch to
sks source tree and deploy the patched
version of the server on any of the sks-keyservers.net?

If so, I could test the client against it.

Best regards

Marian


Dne 2.11.2010 22:57, Johan van Selst napsal(a):

> Marian Kechlibar wrote:
>> the modification with limit is good. This could be easy and
>> straightforward. I would still very much like Content-Length to
>> be present in the header. This makes things so much easier on a
>> slow network.
>
> This should be simple enough to add. Something like the patch
> below might do the trick.
>
>
> Johan
>
> --- a/wserver.ml 2010-11-02 22:52:40.766457000 +0100 +++
> b/wserver.ml 2010-11-02 22:54:47.593314000 +0100 @@ -239,6 +239,7
> @@ let send_result cout ?(error_code = 200) ?(content_type =
> "text/html; charset=UTF-8") body = fprintf cout "HTTP/1.0 %03d
> OK\r\n" error_code; fprintf cout "Server: sks_www/%s\r\n" version;
> + fprintf cout "Content-length: %u\r\n" (String.length body + 2);
> fprintf cout "Content-type: %s\r\n\r\n" content_type; fprintf cout
> "%s\r\n" body; flush cout

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
 
iQIcBAEBAgAGBQJM0QLhAAoJEOJiGpwt9DuCkNUP/1XE3A0xO6YcZeg1/fkl11Ob
OBVPebkp/NfPrt7vtMTSBhgXH19TLwJ+VgfQcjFPRgekQ2C3raDjLwasReVI+7EG
kCdo6zb8OAXXRqT55u2eHRfdb/0SfNzYVYm6+kSb5nbp3PYocWjSiJv93wov8sgt
iAMxDVyFbXcigvH738fmz1sPkIcdnA+AWkm22SjaNq+2nO9lktkveBpCSbS81qxD
F4LEkWj1BiQwRdmk5L9vB+oH1kLhrrnh91Ih1kNAB8sYoXVjLyxtG/PUryaPaLdW
DAEd4zFVdGIzjAgFoknb7TNIs5cJ/YHlO0rdvq3g4ieoeAjlihZxrFHEAmPwsv/Y
mqRtjiYE4LOQOp19SA34Y2Ky4DZn9lcscrVdWR448ruRwAK6hRqQwahznoddivXH
jz3dqv+4gSMWP+Us0v+5ZTc4wtPXcBQjBy+ughbQN0dKSpYt3oNn9DAJDyvfSROM
SKFd6oj19l/4AauefaRAx7tUBb4Xae7gJFl8fu5eO3Iq6XMOACojgoItVzFlBoNr
S06TKIDWqWkV57r7st+83qbmPvrr7ax8B2h+7Do8hVGsdpsYRhtCoBo+9xXTJdJW
l1V5fmhwwN4CTppnCB5/XZgKX2fk4TJKuCzwIFVWnPJHxHO7LRug/eVZXcixMkGr
XM/DZnhIpyx+E5Naqs7F
=FWlJ
-----END PGP SIGNATURE-----


_______________________________________________
Sks-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/sks-devel
Reply | Threaded
Open this post in threaded view
|

Re: SKS, Content-Length and HEAD requests

Johan van Selst
Marian Kechlibar wrote:
> Would anybody here be willing to add Johan's Content-Length patch to
> sks source tree and deploy the patched
> version of the server on any of the sks-keyservers.net?

This is deployed on the server that I control, keyserver.stack.nl.


Johan

_______________________________________________
Sks-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/sks-devel

attachment0 (201 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: SKS, Content-Length and HEAD requests

Marian Kechlibar

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
 
Thank you for good news, we'll try it today.

Best regards

Marian

Dne 3.11.2010 10:52, Johan van Selst napsal(a):
> Marian Kechlibar wrote:
>> Would anybody here be willing to add Johan's Content-Length patch
>> to sks source tree and deploy the patched version of the server
>> on any of the sks-keyservers.net?
>
> This is deployed on the server that I control, keyserver.stack.nl.
>
>
> Johan

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
 
iQIcBAEBAgAGBQJM0TLdAAoJEOJiGpwt9DuCB3YP/iGXzoQSXN7SKLTQU57tigK/
CApOVoaARce2qM24SP5iFxR/NGhoq/Re/Tja/0ybwenxwDFT7mMo/UzCeXnrxHo4
CvAzyNgTH3I+wNi440SyJw/ahYDV9pFrs7hLPpXBwRl1w5BHz80IkKfvKcWZ5DIK
G2rGFX5/d8g7dhIStCtm53zpjj/vWMslDSRxpKZdtmdWVct15h0LcYaF5NfDsU7m
vaczvjkcvlfKqa66ioSxFYv+JfS1Nz9iDUaESgeecegQUvze/4cxKLwq3P4yN3Co
LcvDNbh3E0p78PhSJSZs+NLRj2x4B4GYqfWtysIKms/SzQE0Zc08jgbqxJ6Eht28
/vNPfVSdyHkvXy1TpjAkk5oScV1NxG5JkCcQMJYFG7w07GM9fF/fO4X2QatbwnSC
o4Si+ApfEEsGcnXUYW5zZyyT8O8N+nzjYZSNUKq9Wh8+4YL4rFwRXYSys95DLD/s
gx7e9Hmja3ZSziilsgrimH2OSUBvbTiHSTRYXRTNu608w0vXrrTbxyzYexc6QmW4
zEqvK2Xv5matR2ym+NAmAE4JziC/DhPP7s6Qmbwg+D6Lky9z37CjZeRZx8jV3txY
9lIsVG8H6rWqL3EFuyuw7K0yghBZFu3xouJ+mbv4BVz0Z3xXZQZLaSxZLZbpPxrT
vfc1NZl/wfsh+YAcFrTN
=5KQ5
-----END PGP SIGNATURE-----


_______________________________________________
Sks-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/sks-devel