Warnings in Luracast/Restler (Dolibarr 4.0.1)

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Warnings in Luracast/Restler (Dolibarr 4.0.1)

Nicolas Dorigny - datætic
Hello,

I upgraded from 3.9.3 to 4.0.1 and I had warnings in the webservice Rest explorer (/htdocs/api/admin/explorer.php) and in every webservice call:

Warning: substr() expects parameter 1 to be string, array given in htdocs/includes/restler/framework/Luracast/Re

This is a known issue in Luracast/Restler that has been corrected:
https://github.com/Luracast/Restler/issues/540

I upgraded locally to the latest Luracast/Restler and the warnings disappeared.

The library should be updated in Dolibarr sources.

--
dataetic

Nicolas Dorigny
Consultant - Développeur web freelance
[hidden email] | <a href="tel:0561870189" style="color: #606060 !important; text-decoration: none !important;">05 61 87 01 89 | <a href="tel:0665684464" style="color: #606060 !important; text-decoration: none !important;">06 65 68 44 64

 


_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
Reply | Threaded
Open this post in threaded view
|

Re: Warnings in Luracast/Restler (Dolibarr 4.0.1)

Doursenaud, Raphaël
Hi Nicolas,

External libraries are pinned down in releases. I don't think Laurent will be wanting to update it in 4.x.
The next window for updating is 5.x (currently develop) and it seems already fixed. See https://github.com/Dolibarr/dolibarr/issues/4912

If you use the repository, you should be able to update your version locally using composer : composer require --no-dev restler/framework:3.0.0-RC6
Just create a branch before ;)

Regards,

Raphaël Doursenaud
Directeur technique (CTO)
+33 (0)5 35 53 97 13 - +33 (0)6 68 48 20 10

2016-10-12 14:30 GMT+02:00 Nicolas Dorigny - datætic <[hidden email]>:
Hello,

I upgraded from 3.9.3 to 4.0.1 and I had warnings in the webservice Rest explorer (/htdocs/api/admin/explorer.php) and in every webservice call:

Warning: substr() expects parameter 1 to be string, array given in htdocs/includes/restler/framework/Luracast/Re

This is a known issue in Luracast/Restler that has been corrected:
https://github.com/Luracast/Restler/issues/540

I upgraded locally to the latest Luracast/Restler and the warnings disappeared.

The library should be updated in Dolibarr sources.

--
dataetic

Nicolas Dorigny
Consultant - Développeur web freelance
[hidden email] | <a href="tel:0561870189" style="color:#606060!important;text-decoration:none!important" target="_blank">05 61 87 01 89 | <a href="tel:0665684464" style="color:#606060!important;text-decoration:none!important" target="_blank">06 65 68 44 64

 


_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev



Technopole Hélioparc
2 avenue du Président Pierre Angot
64053 PAU CEDEX 9
SARL GPC.solutions au capital de 7 500 € - R.C.S. PAU 528 995 921

_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
Reply | Threaded
Open this post in threaded view
|

Re: Warnings in Luracast/Restler (Dolibarr 4.0.1)

Nicolas Dorigny - datætic
I dont use the repository, I upgrade with the sources distributed in ZIP.

This means the REST webservices will be broken till 5.0 ?

--
dataetic

Nicolas Dorigny
Consultant - Développeur web freelance
[hidden email] | <a href="tel:0561870189" style="color: #606060 !important; text-decoration: none !important;">05 61 87 01 89 | <a href="tel:0665684464" style="color: #606060 !important; text-decoration: none !important;">06 65 68 44 64

 

Le 12/10/2016 à 14:50, Doursenaud, Raphaël a écrit :
Hi Nicolas,

External libraries are pinned down in releases. I don't think Laurent will be wanting to update it in 4.x.
The next window for updating is 5.x (currently develop) and it seems already fixed. See https://github.com/Dolibarr/dolibarr/issues/4912

If you use the repository, you should be able to update your version locally using composer : composer require --no-dev restler/framework:3.0.0-RC6
Just create a branch before ;)

Regards,

Raphaël Doursenaud
Directeur technique (CTO)
+33 (0)5 35 53 97 13 - +33 (0)6 68 48 20 10

2016-10-12 14:30 GMT+02:00 Nicolas Dorigny - datætic <[hidden email]>:
Hello,

I upgraded from 3.9.3 to 4.0.1 and I had warnings in the webservice Rest explorer (/htdocs/api/admin/explorer.php) and in every webservice call:

Warning: substr() expects parameter 1 to be string, array given in htdocs/includes/restler/framework/Luracast/Re

This is a known issue in Luracast/Restler that has been corrected:
https://github.com/Luracast/Restler/issues/540

I upgraded locally to the latest Luracast/Restler and the warnings disappeared.

The library should be updated in Dolibarr sources.

--
dataetic

Nicolas Dorigny
Consultant - Développeur web freelance
[hidden email] | <a moz-do-not-send="true" href="tel:0561870189" style="color:#606060!important;text-decoration:none!important" target="_blank">05 61 87 01 89 | <a moz-do-not-send="true" href="tel:0665684464" style="color:#606060!important;text-decoration:none!important" target="_blank">06 65 68 44 64

 


_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev



Technopole Hélioparc
2 avenue du Président Pierre Angot
64053 PAU CEDEX 9
SARL GPC.solutions au capital de 7 500 € - R.C.S. PAU 528 995 921


_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev


_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
Reply | Threaded
Open this post in threaded view
|

Re: Warnings in Luracast/Restler (Dolibarr 4.0.1)

Doursenaud, Raphaël
The sane think to do would be to backport that fix, yes.
But other regressions may creep in since, AFAIK, there's no test coverage.
Unfortunately, only Laurent (@eldy) knows…

Writing these tests would be a great help ;)

Raphaël Doursenaud
Directeur technique (CTO)
+33 (0)5 35 53 97 13 - +33 (0)6 68 48 20 10

2016-10-12 14:58 GMT+02:00 Nicolas Dorigny - datætic <[hidden email]>:
I dont use the repository, I upgrade with the sources distributed in ZIP.

This means the REST webservices will be broken till 5.0 ?

--
dataetic

Nicolas Dorigny
Consultant - Développeur web freelance
[hidden email] | <a href="tel:0561870189" style="color:#606060!important;text-decoration:none!important" target="_blank">05 61 87 01 89 | <a href="tel:0665684464" style="color:#606060!important;text-decoration:none!important" target="_blank">06 65 68 44 64

 

Le 12/10/2016 à 14:50, Doursenaud, Raphaël a écrit :
Hi Nicolas,

External libraries are pinned down in releases. I don't think Laurent will be wanting to update it in 4.x.
The next window for updating is 5.x (currently develop) and it seems already fixed. See https://github.com/Dolibarr/dolibarr/issues/4912

If you use the repository, you should be able to update your version locally using composer : composer require --no-dev restler/framework:3.0.0-RC6
Just create a branch before ;)

Regards,

Raphaël Doursenaud
Directeur technique (CTO)
<a href="tel:%2B33%20%280%295%2035%2053%2097%2013" value="+33535539713" target="_blank">+33 (0)5 35 53 97 13 - <a href="tel:%2B33%20%280%296%2068%2048%2020%2010" value="+33668482010" target="_blank">+33 (0)6 68 48 20 10

2016-10-12 14:30 GMT+02:00 Nicolas Dorigny - datætic <[hidden email]>:
Hello,

I upgraded from 3.9.3 to 4.0.1 and I had warnings in the webservice Rest explorer (/htdocs/api/admin/explorer.php) and in every webservice call:

Warning: substr() expects parameter 1 to be string, array given in htdocs/includes/restler/framework/Luracast/Re

This is a known issue in Luracast/Restler that has been corrected:
https://github.com/Luracast/Restler/issues/540

I upgraded locally to the latest Luracast/Restler and the warnings disappeared.

The library should be updated in Dolibarr sources.

--
dataetic

Nicolas Dorigny
Consultant - Développeur web freelance
[hidden email] | <a href="tel:0561870189" style="color:#606060!important;text-decoration:none!important" target="_blank">05 61 87 01 89 | <a href="tel:0665684464" style="color:#606060!important;text-decoration:none!important" target="_blank">06 65 68 44 64

 


_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev



Technopole Hélioparc
2 avenue du Président Pierre Angot
64053 PAU CEDEX 9
SARL GPC.solutions au capital de 7 500 € - R.C.S. PAU 528 995 921


_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev


_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev



Technopole Hélioparc
2 avenue du Président Pierre Angot
64053 PAU CEDEX 9
SARL GPC.solutions au capital de 7 500 € - R.C.S. PAU 528 995 921

_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
Reply | Threaded
Open this post in threaded view
|

Re: Warnings in Luracast/Restler (Dolibarr 4.0.1)

Nicolas Dorigny - datætic
In reply to this post by Doursenaud, Raphaël
I created a local dev environment, and cloned dolibarr-developp.
The warnings are still here.

In composer.json, restler version is on 3.0.0-RC6, but on the project page it is on RC5 :
https://github.com/Luracast/Restler

So I ran `composer require restler/framework:3.0.0-RC5` and after composer update the warnings disappeared.

BTW, I noticed that restler's Autoloader class has been modified in dolibarr-developp : I ran `composer require restler/framework:3.0.0-RC6` to restore the previous version and the autoloading didn't work anymore, I had to copy the modified Autoloader.php from dolibarr-developp

--
dataetic

Nicolas Dorigny
Consultant - Développeur web freelance
[hidden email] | <a href="tel:0561870189" style="color: #606060 !important; text-decoration: none !important;">05 61 87 01 89 | <a href="tel:0665684464" style="color: #606060 !important; text-decoration: none !important;">06 65 68 44 64

 

Le 12/10/2016 à 14:50, Doursenaud, Raphaël a écrit :
Hi Nicolas,

External libraries are pinned down in releases. I don't think Laurent will be wanting to update it in 4.x.
The next window for updating is 5.x (currently develop) and it seems already fixed. See https://github.com/Dolibarr/dolibarr/issues/4912

If you use the repository, you should be able to update your version locally using composer : composer require --no-dev restler/framework:3.0.0-RC6
Just create a branch before ;)

Regards,

Raphaël Doursenaud
Directeur technique (CTO)
+33 (0)5 35 53 97 13 - +33 (0)6 68 48 20 10

2016-10-12 14:30 GMT+02:00 Nicolas Dorigny - datætic <[hidden email]>:
Hello,

I upgraded from 3.9.3 to 4.0.1 and I had warnings in the webservice Rest explorer (/htdocs/api/admin/explorer.php) and in every webservice call:

Warning: substr() expects parameter 1 to be string, array given in htdocs/includes/restler/framework/Luracast/Re

This is a known issue in Luracast/Restler that has been corrected:
https://github.com/Luracast/Restler/issues/540

I upgraded locally to the latest Luracast/Restler and the warnings disappeared.

The library should be updated in Dolibarr sources.

--
dataetic

Nicolas Dorigny
Consultant - Développeur web freelance
[hidden email] | <a moz-do-not-send="true" href="tel:0561870189" style="color:#606060!important;text-decoration:none!important" target="_blank">05 61 87 01 89 | <a moz-do-not-send="true" href="tel:0665684464" style="color:#606060!important;text-decoration:none!important" target="_blank">06 65 68 44 64

 


_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev



Technopole Hélioparc
2 avenue du Président Pierre Angot
64053 PAU CEDEX 9
SARL GPC.solutions au capital de 7 500 € - R.C.S. PAU 528 995 921


_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev


_______________________________________________
Dolibarr-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev