[bug #41434] Compilation fails on android due <sys/termios.h> being included instead of <termios.h>

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[bug #41434] Compilation fails on android due <sys/termios.h> being included instead of <termios.h>

Eric L.-2
URL:
  <http://savannah.nongnu.org/bugs/?41434>

                 Summary: Compilation fails on android due <sys/termios.h>
being included instead of <termios.h>
                 Project: WeeChat
            Submitted by: None
            Submitted on: Sun 02 Feb 2014 12:36:42 PM UTC
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
         Originator Name: Fredrik Fornwall
        Originator Email: [hidden email]
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 0.4.3-dev
                IRC nick: fornwall

    _______________________________________________________

Details:

Android does not have <sys/termios.h> but <termios.h>.

I believe that <termios.h> is the portable and standard file to include
anyway:

* http://www.gnu.org/software/libc/manual/html_node/Noncanon-Example.html
* http://pubs.opengroup.org/onlinepubs/7990989799/xsh/termios.h.html

The attached patch does the sys/termios.h => termios.h replacement.

The change in gui-curses.h is not strictly required since it's guarded by
ifdef __CYGWIN__, but we might as well do the change there for consistency.




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?41434>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/


_______________________________________________
Weechat-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/weechat-dev
Reply | Threaded
Open this post in threaded view
|

[bug #41434] Compilation fails on android due <sys/termios.h> being included instead of <termios.h>

Eric L.-2
Additional Item Attachment, bug #41434 (project weechat):

File name: termios_h_include_path.patch   Size:0 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?41434>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/


_______________________________________________
Weechat-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/weechat-dev
Reply | Threaded
Open this post in threaded view
|

[bug #41434] Compilation fails on android due <sys/termios.h> being included instead of <termios.h>

Eric L.-2
Update of bug #41434 (project weechat):

                Category:                    None => compilation            
              Item Group:                    None => compile/install        
                  Status:                    None => Fixed                  
             Assigned to:                    None => flashcode              
                 Release:               0.4.3-dev => 0.4.2                  

    _______________________________________________________

Follow-up Comment #1:

Thanks, committed.

So I did that:
- I removed the include for Cygwin: I tested and it looks like the include is
not needed at all
- the include in gui-curses-window.c was added for Solaris, but I don't have
any way to test on this OS, so I replaced the include here (your patch), in
the hope it is still OK on Solaris.

I tested on GNU/Hurd and OpenBSD, no problem with the patch.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?41434>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/


_______________________________________________
Weechat-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/weechat-dev