help with applying git pull requests

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

help with applying git pull requests

Shawn Betts-3
Hi folks,

I moved the repo to github (even though its still also hosted on
savannah) a while back so we could use their wiki facilities. But now
people are sending me pull requests and I have absolutely no time to
go through them and apply the good ones. unfortunately, now they're
just rotting in my pull request queue instead of rotting on the
mailing list. Can someone tell me if there's a way to have other
people (like anyone with commit access to savannah or really anyone
who is active and competent here) go through those pull requests and
apply them? Maybe by having some kind of shared github repo?

-Shawn

_______________________________________________
Stumpwm-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/stumpwm-devel
Reply | Threaded
Open this post in threaded view
|

Re: help with applying git pull requests

Michael Filonenko
Hi.

You can add devs here:
https://github.com/sabetts/stumpwm/settings/collaboration

2013/6/26 Shawn Betts <[hidden email]>:

>
> I moved the repo to github (even though its still also hosted on
> savannah) a while back so we could use their wiki facilities. But now
> people are sending me pull requests and I have absolutely no time to
> go through them and apply the good ones. unfortunately, now they're
> just rotting in my pull request queue instead of rotting on the
> mailing list. Can someone tell me if there's a way to have other
> people (like anyone with commit access to savannah or really anyone
> who is active and competent here) go through those pull requests and
> apply them? Maybe by having some kind of shared github repo?




--
With best regards, Michael Filonenko

_______________________________________________
Stumpwm-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/stumpwm-devel
Reply | Threaded
Open this post in threaded view
|

Re: help with applying git pull requests

Shawn Betts-3
Excellent! Thanks Michael. Are you also volunteering? :)

-Shawn

On Wed, Jun 26, 2013 at 10:49 PM, Michael Filonenko
<[hidden email]> wrote:

> Hi.
>
> You can add devs here:
> https://github.com/sabetts/stumpwm/settings/collaboration
>
> 2013/6/26 Shawn Betts <[hidden email]>:
>>
>> I moved the repo to github (even though its still also hosted on
>> savannah) a while back so we could use their wiki facilities. But now
>> people are sending me pull requests and I have absolutely no time to
>> go through them and apply the good ones. unfortunately, now they're
>> just rotting in my pull request queue instead of rotting on the
>> mailing list. Can someone tell me if there's a way to have other
>> people (like anyone with commit access to savannah or really anyone
>> who is active and competent here) go through those pull requests and
>> apply them? Maybe by having some kind of shared github repo?
>
>
>
>
> --
> With best regards, Michael Filonenko

_______________________________________________
Stumpwm-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/stumpwm-devel
Reply | Threaded
Open this post in threaded view
|

Re: help with applying git pull requests

Michael Filonenko
I made antialiased fonts and merged stumptray project into my repo.
These are required some libraries from quicklisp. So I am not sure
that these changes satisfy stumpwm minimalistic conception.

2013/6/27 Shawn Betts <[hidden email]>:
> Are you also volunteering




--
With best regards, Michael Filonenko

_______________________________________________
Stumpwm-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/stumpwm-devel
Reply | Threaded
Open this post in threaded view
|

Re: help with applying git pull requests

David Bjergaard
Hi,

I'm aware of the stumptray project which I would vote for going into a
contrib module if possible...  The reason I'm writing is that you also
submitted a patch for full screen games that I think would be
appropriate for a pull request. (I needed the patch recently and had to
dig to find the pastebin for it.)

I would volunteer, but my lisp skills are not that great, and my
X11/Window Manager skills are far worse.  Thanks for the great software
though!

Cheers,

    Dave

Michael Filonenko <[hidden email]> writes:

> I made antialiased fonts and merged stumptray project into my repo.
> These are required some libraries from quicklisp. So I am not sure
> that these changes satisfy stumpwm minimalistic conception.
>
> 2013/6/27 Shawn Betts <[hidden email]>:
>> Are you also volunteering
>
>
>
>
> --
> With best regards, Michael Filonenko
>
> _______________________________________________
> Stumpwm-devel mailing list
> [hidden email]
> https://lists.nongnu.org/mailman/listinfo/stumpwm-devel

_______________________________________________
Stumpwm-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/stumpwm-devel
Reply | Threaded
Open this post in threaded view
|

Re: help with applying git pull requests

David Bjergaard
Hi All,

It doesn't look like this has moved since it was proposed, and there are a lot of pull requests/issues in the queue that would benefit the stumpwm community at least as far as fixing bugs and adding new contrib modules.  I said earlier that I was uncomfortable volunteering because of my lack of X11 and lisp skills, but if no one else is stepping up, I will volunteer.  I feel confident that I can understand the pull requests enough to approve them on a timescale faster than they are getting addressed now.

Cheers,

      Dave


On Thu, Jun 27, 2013 at 9:26 AM, David Bjergaard <[hidden email]> wrote:
Hi,

I'm aware of the stumptray project which I would vote for going into a
contrib module if possible...  The reason I'm writing is that you also
submitted a patch for full screen games that I think would be
appropriate for a pull request. (I needed the patch recently and had to
dig to find the pastebin for it.)

I would volunteer, but my lisp skills are not that great, and my
X11/Window Manager skills are far worse.  Thanks for the great software
though!

Cheers,

    Dave

Michael Filonenko <[hidden email]> writes:

> I made antialiased fonts and merged stumptray project into my repo.
> These are required some libraries from quicklisp. So I am not sure
> that these changes satisfy stumpwm minimalistic conception.
>
> 2013/6/27 Shawn Betts <[hidden email]>:
>> Are you also volunteering
>
>
>
>
> --
> With best regards, Michael Filonenko
>
> _______________________________________________
> Stumpwm-devel mailing list
> [hidden email]
> https://lists.nongnu.org/mailman/listinfo/stumpwm-devel


_______________________________________________
Stumpwm-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/stumpwm-devel
Reply | Threaded
Open this post in threaded view
|

Re: help with applying git pull requests

Shawn Betts-3
super, thanks David. I've added you as a collaborator. Let me know if
there's anything else I can do. If anyone else thinks they can help,
please let me know.

-Shawn

On Sun, Jan 26, 2014 at 9:07 AM, David Bjergaard <[hidden email]> wrote:

> Hi All,
>
> It doesn't look like this has moved since it was proposed, and there are a
> lot of pull requests/issues in the queue that would benefit the stumpwm
> community at least as far as fixing bugs and adding new contrib modules.  I
> said earlier that I was uncomfortable volunteering because of my lack of X11
> and lisp skills, but if no one else is stepping up, I will volunteer.  I
> feel confident that I can understand the pull requests enough to approve
> them on a timescale faster than they are getting addressed now.
>
> Cheers,
>
>       Dave
>
>
> On Thu, Jun 27, 2013 at 9:26 AM, David Bjergaard <[hidden email]>
> wrote:
>>
>> Hi,
>>
>> I'm aware of the stumptray project which I would vote for going into a
>> contrib module if possible...  The reason I'm writing is that you also
>> submitted a patch for full screen games that I think would be
>> appropriate for a pull request. (I needed the patch recently and had to
>> dig to find the pastebin for it.)
>>
>> I would volunteer, but my lisp skills are not that great, and my
>> X11/Window Manager skills are far worse.  Thanks for the great software
>> though!
>>
>> Cheers,
>>
>>     Dave
>>
>> Michael Filonenko <[hidden email]> writes:
>>
>> > I made antialiased fonts and merged stumptray project into my repo.
>> > These are required some libraries from quicklisp. So I am not sure
>> > that these changes satisfy stumpwm minimalistic conception.
>> >
>> > 2013/6/27 Shawn Betts <[hidden email]>:
>> >> Are you also volunteering
>> >
>> >
>> >
>> >
>> > --
>> > With best regards, Michael Filonenko
>> >
>> > _______________________________________________
>> > Stumpwm-devel mailing list
>> > [hidden email]
>> > https://lists.nongnu.org/mailman/listinfo/stumpwm-devel
>
>

_______________________________________________
Stumpwm-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/stumpwm-devel