libconfuse 2.7 spec file issues

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

libconfuse 2.7 spec file issues

Dieter GORECKI
Hi,

The spec file currently provided with libconfuse 2.7 is broken, at least with RHEL 6.x x86_64. Here is a list of things that should be fixed in order to make it work :

- the COPYING file doesn't exist
- the "Copyright" tag doesn't exist, it should be "License" instead.

(These 2 points have already been pointed out in a 2009 email in this list...)

- the libraries directory should be lib64 instead of lib
- the package config file is not generated 


Here is a patch to fix these issues :

--- confuse-2.7_orig/libconfuse.spec 2010-02-22 01:44:22.000000000 +0100
+++ confuse-2.7/libconfuse.spec 2014-06-02 20:15:04.901990089 +0200
@@ -29,7 +29,7 @@
 Group: %{_group}
 Packager: Pascal Bleser <[hidden email]>
-Copyright: ISC
+License: ISC
 BuildRoot: %{_tmppath}/build-%{_name}-%{_version}
 BuildRequires:     xmlto doxygen
 Prefix: %{_prefix}
@@ -72,7 +72,8 @@
 CFLAGS="${RPM_OPT_FLAGS}" \
 ./configure \
  --prefix="%{_prefix}" \
- --enable-shared
+ --enable-shared \
+ --libdir="%{_prefix}"/lib64
 
 %build
 %{__make}
@@ -88,7 +89,7 @@
 
 %{__mkdir_p} "${RPM_BUILD_ROOT}%{_pkgdoc}"
 echo -n > _rpm_doc_files_
-for f in AUTHORS COPYING NEWS README; do
+for f in AUTHORS NEWS README; do
  %{__cp} "$f" "${RPM_BUILD_ROOT}%{_pkgdoc}/$f"
  echo "%doc %{_pkgdoc}/$f" >> _rpm_doc_files_
 done
@@ -121,5 +122,6 @@
 %{_libdir}/lib*.a
 %{_libdir}/lib*.la
 %{_libdir}/lib*.so
+%{_libdir}/pkgconfig/*.pc
 %doc %{_mandir}/man*/*
 



I know this project is likely to be dead so I don't have much expectations for my patch to be merged, but I hope it will help save time to people needing to compile rpms ...

Regards,

Dieter


_______________________________________________
Confuse-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/confuse-devel
Reply | Threaded
Open this post in threaded view
|

Re: libconfuse 2.7 spec file issues

J.J. Green
Hi Dieter,

> I know this project is likely to be dead so I don't have much
> expectations for my patch to be merged, but I hope it will help save
> time to people needing to compile rpms ...

It is unfortunate that this project no longer seems to be maintained.
I contributed a rather large patch in 2010 which was never merged.
It is depressing to work on a project and then find that this work
is not used.

Cheers

Jim
--
J.J. Green,  Seaview Sensing Ltd.,
http://seaviewsensing.com

_______________________________________________
Confuse-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/confuse-devel
Reply | Threaded
Open this post in threaded view
|

Re: libconfuse 2.7 spec file issues

Craig McQueen
On 03/06/14 08:20, J.J. Green wrote:

> Hi Dieter,
>
>> I know this project is likely to be dead so I don't have much
>> expectations for my patch to be merged, but I hope it will help save
>> time to people needing to compile rpms ...
>
> It is unfortunate that this project no longer seems to be maintained.
> I contributed a rather large patch in 2010 which was never merged.
> It is depressing to work on a project and then find that this work
> is not used.
>

See in github:
https://github.com/martinh/libconfuse

That seems to be the way to contribute now.

Regards,
Craig McQueen


_______________________________________________
Confuse-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/confuse-devel
Reply | Threaded
Open this post in threaded view
|

Re: libconfuse 2.7 spec file issues

Alvaro Gamez
Hi all

Effectively Martin seems to be somewhat active on github and at least
has merged a couple of patches sent via pull requests.

I remember a while ago Martin offered himself to maintain the project
(is this still true?). Maybe Martin could give him and/or Jim and/or
Dieter commit access to his repository. I think this is free on github
for up to 5 contributors.

If Martin is willing to share control of the code with someone with
the available time it would require to do the job, I think these
patches could be merged faster. The project itself could be regarded
as almost complete, save for the few bugs that there may be or appear
and new functionality that can be implemented, so all in all it
shouldn't be much of a burden.

What are your ideas?

Regards,

Alvaro


2014-06-03 4:55 GMT+02:00 Craig McQueen <[hidden email]>:

> On 03/06/14 08:20, J.J. Green wrote:
>>
>> Hi Dieter,
>>
>>> I know this project is likely to be dead so I don't have much
>>> expectations for my patch to be merged, but I hope it will help save
>>> time to people needing to compile rpms ...
>>
>>
>> It is unfortunate that this project no longer seems to be maintained.
>> I contributed a rather large patch in 2010 which was never merged.
>> It is depressing to work on a project and then find that this work
>> is not used.
>>
>
> See in github:
> https://github.com/martinh/libconfuse
>
> That seems to be the way to contribute now.
>
> Regards,
> Craig McQueen
>
>
>
> _______________________________________________
> Confuse-devel mailing list
> [hidden email]
> https://lists.nongnu.org/mailman/listinfo/confuse-devel



--
Álvaro Gámez Machado

_______________________________________________
Confuse-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/confuse-devel
Reply | Threaded
Open this post in threaded view
|

Re: libconfuse 2.7 spec file issues

Martin Hedenfalk-4
In reply to this post by Dieter GORECKI
On Mon, Jun 02, 2014 at 08:23:16PM +0200, Dieter GORECKI wrote:

> Hi,
>
> The spec file currently provided with libconfuse 2.7 is broken, at least
> with RHEL 6.x x86_64. Here is a list of things that should be fixed in
> order to make it work :
>
> - the COPYING file doesn't exist
> - the "Copyright" tag doesn't exist, it should be "License" instead.
>
> (These 2 points have already been pointed out in a 2009 email in this
> list...)
>
> - the libraries directory should be lib64 instead of lib
> - the package config file is not generated
>
>
> Here is a patch to fix these issues :

this doesn't apply. fix the patch, or send a PR via the github repo.

        .martin

_______________________________________________
Confuse-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/confuse-devel
Reply | Threaded
Open this post in threaded view
|

Re: libconfuse 2.7 spec file issues

Martin Hedenfalk-4
In reply to this post by Alvaro Gamez
On Tue, Jun 03, 2014 at 09:42:33AM +0200, Alvaro Gamez wrote:

> Hi all
>
> Effectively Martin seems to be somewhat active on github and at least
> has merged a couple of patches sent via pull requests.
>
> I remember a while ago Martin offered himself to maintain the project
> (is this still true?). Maybe Martin could give him and/or Jim and/or
> Dieter commit access to his repository. I think this is free on github
> for up to 5 contributors.
>
> If Martin is willing to share control of the code with someone with
> the available time it would require to do the job, I think these
> patches could be merged faster. The project itself could be regarded
> as almost complete, save for the few bugs that there may be or appear
> and new functionality that can be implemented, so all in all it
> shouldn't be much of a burden.
>
> What are your ideas?

If anyone want to maintain libconfuse, they need to step forward.

        .martin

_______________________________________________
Confuse-devel mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/confuse-devel