[monit-dev] Consider debian patch for inclusion

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[monit-dev] Consider debian patch for inclusion

Sergey B Kirpichev
Hello,

Would you like to hide priority < LOG_INFO messages from displaying on
stderr? (patch 08)

http://anonscm.debian.org/gitweb/?p=collab-maint/monit.git;a=tree;f=debian/patches

_______________________________________________
monit-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/monit-dev
Reply | Threaded
Open this post in threaded view
|

Re: [monit-dev] Consider debian patch for inclusion

martinp@tildeslash.com
Hello Sergey,

the patch idea is useful (filter out the real errors from other messages on the stderr). The display of the LogInfo+LogDebug is however useful when monit is running with the -vI options (verbose mode in foreground) for debug. In this case the output should be displayed to the user on the standard output, which still allows for filtering of the errors only by redirecting the standard output.

The attached patch will log the message either to stderr or stdout based on the priority.

Regards,
Martin







On Sep 10, 2012, at 12:07 PM, Sergey B Kirpichev <[hidden email]> wrote:

> Hello,
>
> Would you like to hide priority < LOG_INFO messages from displaying on
> stderr? (patch 08)
>
> http://anonscm.debian.org/gitweb/?p=collab-maint/monit.git;a=tree;f=debian/patches
>
> _______________________________________________
> monit-dev mailing list
> [hidden email]
> https://lists.nongnu.org/mailman/listinfo/monit-dev

_______________________________________________
monit-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/monit-dev

log.patch (760 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [monit-dev] Consider debian patch for inclusion

Sergey B Kirpichev
(sorry for late answer)

On Tue, Sep 11, 2012 at 8:06 PM, Martin Pala <[hidden email]> wrote:
> The attached patch will log the message either to stderr or stdout based on the priority.

Ok, debian patch was updated.  Would you like to include this?

PS: Please, take look on patch 09 (check /run first for piddir).

_______________________________________________
monit-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/monit-dev
Reply | Threaded
Open this post in threaded view
|

Re: [monit-dev] Consider debian patch for inclusion

martinp@tildeslash.com
Hello,

the stderr fix is part of next monit release, thanks for the initial patch :)

I have checked the patch 09 - the patch looks OK, but the /run seems to be currently specific for Debian only ... i think it'll be better to keep just /var/run in monit release as this way it's general for most platforms and distributions.

Regards,
Martin



On Dec 10, 2012, at 10:49 AM, Sergey Kirpichev <[hidden email]> wrote:

> (sorry for late answer)
>
> On Tue, Sep 11, 2012 at 8:06 PM, Martin Pala <[hidden email]> wrote:
>> The attached patch will log the message either to stderr or stdout based on the priority.
>
> Ok, debian patch was updated.  Would you like to include this?
>
> PS: Please, take look on patch 09 (check /run first for piddir).
>
> _______________________________________________
> monit-dev mailing list
> [hidden email]
> https://lists.nongnu.org/mailman/listinfo/monit-dev


_______________________________________________
monit-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/monit-dev
Reply | Threaded
Open this post in threaded view
|

Re: [monit-dev] Consider debian patch for inclusion

Sergey B Kirpichev
On Mon, Dec 10, 2012 at 3:36 PM, Martin Pala <[hidden email]> wrote:
> the stderr fix is part of next monit release

Public repo would be useful to avoid dumb questions ;)

> I have checked the patch 09 - the patch looks OK, but the /run seems
> to be currently specific for Debian only ...

No.  Please, read: http://wiki.debian.org/ReleaseGoals/RunDirectory

> i think it'll be better to keep just /var/run in monit release as
> this way it's general for most platforms and distributions.

-->8--
/run is being introduced by Fedora and SuSE and others will follow. It
has been proposed to the FHS for standardization.
-->8--

It's Linux-specific now.

_______________________________________________
monit-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/monit-dev
Reply | Threaded
Open this post in threaded view
|

Re: [monit-dev] Consider debian patch for inclusion

martinp@tildeslash.com

On Dec 10, 2012, at 1:04 PM, Sergey Kirpichev <[hidden email]> wrote:

> On Mon, Dec 10, 2012 at 3:36 PM, Martin Pala <[hidden email]> wrote:
>> the stderr fix is part of next monit release
>
> Public repo would be useful to avoid dumb questions ;)


We can add the public repository when the monit refactoring is finished.



>> I have checked the patch 09 - the patch looks OK, but the /run seems
>> to be currently specific for Debian only ...
>
> No.  Please, read: http://wiki.debian.org/ReleaseGoals/RunDirectory
>
>> i think it'll be better to keep just /var/run in monit release as
>> this way it's general for most platforms and distributions.
>
> -->8--
> /run is being introduced by Fedora and SuSE and others will follow. It
> has been proposed to the FHS for standardization.
> -->8--
>
> It's Linux-specific now.



OK, then it'll make sense to add "/run" support - we'll look on it.

Regards,
Martin


_______________________________________________
monit-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/monit-dev